Skip to content

Captures AI actions feedback #4475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 7, 2025
Merged

Captures AI actions feedback #4475

merged 9 commits into from
Jul 7, 2025

Conversation

@sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Jul 4, 2025 •
edited
Loading

Description

solves: #4449

image

image

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb sergeibbb force-pushed the 4449-capture-commit-generation-feedback branch 10 times, most recently from f171298 to 2218063 Compare July 4, 2025 18:56
sergeibbb added a commit that referenced this pull request Jul 7, 2025
@sergeibbb
Adds AI feedback toolbar actions to markdown previews
731dbf9 
Introduces dedicated "Helpful" and "Not helpful" toolbar commands for
AI-generated markdown previews, allowing users to quickly provide
positive or negative feedback directly from the editor UI. Feedback
context is extracted from document metadata when telemetry is enabled,
improving the feedback workflow and user experience for AI-assisted
features.
(#4449, #4475)
@sergeibbb sergeibbb force-pushed the 4449-capture-commit-generation-feedback branch from 2218063 to 5871cbe Compare July 7, 2025 11:59
sergeibbb added a commit that referenced this pull request Jul 7, 2025
@sergeibbb
Improves when clause to hide feedback buttons when telemetry is disabled
b043cc5 
(#4449, #4475)
sergeibbb added a commit that referenced this pull request Jul 7, 2025
@sergeibbb
Adjusts order of buttons in the toolbar: moves "Regenerate" to the right
7042d6e 
(#4449, #4475)
sergeibbb added a commit that referenced this pull request Jul 7, 2025
@sergeibbb
Adds feedback buttons to the "Explain" family of AI actions
3654f10 
(#4449, #4475)
sergeibbb added a commit that referenced this pull request Jul 7, 2025
@sergeibbb
Add AI request ID to feedback telemetry events
5871cbe 
Includes a unique AI request identifier in feedback telemetry to enable
improved traceability and correlation of feedback to specific AI
requests. Updates documentation and relevant interfaces to reflect the
new field.
(#4449, #4475)
@sergeibbb sergeibbb changed the title 4449 capture commit generation feedback Captures AI actions feedback Jul 7, 2025
@sergeibbb sergeibbb marked this pull request as ready for review July 7, 2025 12:11
@sergeibbb sergeibbb linked an issue Jul 7, 2025 that may be closed by this pull request
Capture sentiment feedback about AI feature effectiveness #4449
Closed
4 tasks
sergeibbb added a commit that referenced this pull request Jul 7, 2025
@sergeibbb
Adds a CHANGELOG note about "feedback on AI" buttons
774305d 
(#4449, #4475)
sergeibbb added a commit that referenced this pull request Jul 7, 2025
@sergeibbb
Handles deserialization of resetsOn dates in feedback context
caf6f1e 
Ensures that feedback context objects properly convert resetsOn
fields from strings back to Date objects after deserialization.
Prevents potential errors from invalid date strings by setting
them to undefined and logging a warning. Improves robustness
when restoring usage limits from metadata.

(#4449, #4475)
sergeibbb added a commit that referenced this pull request Jul 7, 2025
@sergeibbb
Refactors feedback context extraction for reuse
a530b5e 
Consolidates duplicate logic for extracting feedback context into a shared function to improve maintainability and reduce code repetition. Enhances consistency and simplifies error handling for feedback commands.

(#4449, #4475)
sergeibbb added 6 commits July 7, 2025 18:04
@sergeibbb @eamodio
Adds AI feedback toolbar actions to markdown previews
5f561a6 
Introduces dedicated "Helpful" and "Not helpful" toolbar commands for
AI-generated markdown previews, allowing users to quickly provide
positive or negative feedback directly from the editor UI. Feedback
context is extracted from document metadata when telemetry is enabled,
improving the feedback workflow and user experience for AI-assisted
features.
(#4449, #4475)
@sergeibbb @eamodio
Improves when clause to hide feedback buttons when telemetry is disabled
a04ae73 
(#4449, #4475)
@sergeibbb @eamodio
Adjusts order of buttons in the toolbar: moves "Regenerate" to the right
cc7e983 
(#4449, #4475)
@sergeibbb @eamodio
Adds feedback buttons to the "Explain" family of AI actions
79dcb85 
(#4449, #4475)
@sergeibbb @eamodio
Add AI request ID to feedback telemetry events
ba3fc39 
Includes a unique AI request identifier in feedback telemetry to enable
improved traceability and correlation of feedback to specific AI
requests. Updates documentation and relevant interfaces to reflect the
new field.
(#4449, #4475)
@sergeibbb @eamodio
Adds a CHANGELOG note about "feedback on AI" buttons
314abea 
(#4449, #4475)
sergeibbb and others added 3 commits July 7, 2025 18:04
@sergeibbb @eamodio
Handles deserialization of resetsOn dates in feedback context
11b5c6b 
Ensures that feedback context objects properly convert resetsOn
fields from strings back to Date objects after deserialization.
Prevents potential errors from invalid date strings by setting
them to undefined and logging a warning. Improves robustness
when restoring usage limits from metadata.

(#4449, #4475)
@sergeibbb @eamodio
Refactors feedback context extraction for reuse
2905dbc 
Consolidates duplicate logic for extracting feedback context into a shared function to improve maintainability and reduce code repetition. Enhances consistency and simplifies error handling for feedback commands.

(#4449, #4475)
@eamodio
Refactors to use helpful/unhelpful sentiment
f0a1b27 
 - Replaces positive/negative with helpful/unhelpful terminology
 - Adds visual state tracking with filled/unfilled thumbs up/down icons
 - Updates telemetry to focus on sentiment and unhelpful reasons
 - Improves AI context in AI markdown URIs
 - Only shows "custom" feedback input if "Other" is selected
@eamodio eamodio force-pushed the 4449-capture-commit-generation-feedback branch from a530b5e to f0a1b27 Compare July 7, 2025 23:41
@eamodio eamodio merged commit fd99863 into main Jul 7, 2025
2 checks passed
eamodio pushed a commit that referenced this pull request Jul 7, 2025
@sergeibbb @eamodio
Adds AI feedback toolbar actions to markdown previews
b78e0d0 
Introduces dedicated "Helpful" and "Not helpful" toolbar commands for
AI-generated markdown previews, allowing users to quickly provide
positive or negative feedback directly from the editor UI. Feedback
context is extracted from document metadata when telemetry is enabled,
improving the feedback workflow and user experience for AI-assisted
features.
(#4449, #4475)
eamodio pushed a commit that referenced this pull request Jul 7, 2025
@sergeibbb @eamodio
Improves when clause to hide feedback buttons when telemetry is disabled
c462589 
(#4449, #4475)
eamodio pushed a commit that referenced this pull request Jul 7, 2025
@sergeibbb @eamodio
Adjusts order of buttons in the toolbar: moves "Regenerate" to the right
19196ff 
(#4449, #4475)
eamodio pushed a commit that referenced this pull request Jul 7, 2025
@sergeibbb @eamodio
Adds feedback buttons to the "Explain" family of AI actions
e91852b 
(#4449, #4475)
eamodio pushed a commit that referenced this pull request Jul 7, 2025
@sergeibbb @eamodio
Add AI request ID to feedback telemetry events
476c2d9 
Includes a unique AI request identifier in feedback telemetry to enable
improved traceability and correlation of feedback to specific AI
requests. Updates documentation and relevant interfaces to reflect the
new field.
(#4449, #4475)
eamodio pushed a commit that referenced this pull request Jul 7, 2025
@sergeibbb @eamodio
Adds a CHANGELOG note about "feedback on AI" buttons
761dbe0 
(#4449, #4475)
eamodio pushed a commit that referenced this pull request Jul 7, 2025
@sergeibbb @eamodio
Handles deserialization of resetsOn dates in feedback context
705de8e 
Ensures that feedback context objects properly convert resetsOn
fields from strings back to Date objects after deserialization.
Prevents potential errors from invalid date strings by setting
them to undefined and logging a warning. Improves robustness
when restoring usage limits from metadata.

(#4449, #4475)
eamodio pushed a commit that referenced this pull request Jul 7, 2025
@sergeibbb @eamodio
Refactors feedback context extraction for reuse
9d9370b 
Consolidates duplicate logic for extracting feedback context into a shared function to improve maintainability and reduce code repetition. Enhances consistency and simplifies error handling for feedback commands.

(#4449, #4475)
@sergeibbb sergeibbb deleted the 4449-capture-commit-generation-feedback branch July 8, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eamodio eamodio Awaiting requested review from eamodio

@axosoft-ramint axosoft-ramint Awaiting requested review from axosoft-ramint

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Capture sentiment feedback about AI feature effectiveness

2 participants

@sergeibbb @eamodio